Quantcast

[PATCH] mq: fix the deprecation comment for qsave & qrestore

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] mq: fix the deprecation comment for qsave & qrestore

Dan Villiom Podlaski Christiansen-2
# HG changeset patch
# User Dan Villiom Podlaski Christiansen <[hidden email]>
# Date 1284982262 -7200
# Node ID 0b965ece4f058ed0c66bee26425233adc07b5842
# Parent  6ca072791661e53c9596570490247c0519e12e7e
mq: fix the deprecation comment for qsave & qrestore.

Changeset bcf90e712dc3 deprecated qsave and qrestore. In the
deprecating comment, users were referred to 'rebase --mq' which -- at
the time the message was written -- didn't exist. Currently, on the
default branch, rebase *does* take a '--mq' option, but it probably
doesn't do what Dirkjan expected it to do when he wrote the message.

In the original, deprecating commit, little context was provided as to
why this change was made. Based on my recollection, concensus at the
Paris Sprint in February 2010 was that one of the problems with MQ was
that it exposed far too many commands. Notable among these were qsave
& qrestore: very few core developers understood what they did and even
fewer (none, IIRC) actually used them. However, they couldn't be
removed; not only do the usual backwards compatibility reasons apply,
but the hg book refers to them.

diff --git a/hgext/mq.py b/hgext/mq.py
--- a/hgext/mq.py
+++ b/hgext/mq.py
@@ -2376,7 +2376,7 @@ def rename(ui, repo, patch, name=None, *
 def restore(ui, repo, rev, **opts):
     """restore the queue state saved by a revision (DEPRECATED)
 
-    This command is deprecated, use rebase --mq instead."""
+    This command is deprecated, use :hg:`rebase` instead."""
     rev = repo.lookup(rev)
     q = repo.mq
     q.restore(repo, rev, delete=opts.get('delete'),
@@ -2387,7 +2387,7 @@ def restore(ui, repo, rev, **opts):
 def save(ui, repo, **opts):
     """save current queue state (DEPRECATED)
 
-    This command is deprecated, use rebase --mq instead."""
+    This command is deprecated, use :hg:`rebase` instead."""
     q = repo.mq
     message = cmdutil.logmessage(opts)
     ret = q.save(repo, msg=message)
_______________________________________________
Mercurial-devel mailing list
[hidden email]
http://selenic.com/mailman/listinfo/mercurial-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] mq: fix the deprecation comment for qsave & qrestore

Dan Villiom Podlaski Christiansen-2
On 20 Sep 2010, at 13:33, Dan Villiom Podlaski Christiansen wrote:

> # HG changeset patch
> # User Dan Villiom Podlaski Christiansen <[hidden email]>
> # Date 1284982262 -7200
> # Node ID 0b965ece4f058ed0c66bee26425233adc07b5842
> # Parent  6ca072791661e53c9596570490247c0519e12e7e
> mq: fix the deprecation comment for qsave & qrestore.

Oh, I forgot; this patch should've been marked “stable.”

--

Dan Villiom Podlaski Christiansen
[hidden email]


_______________________________________________
Mercurial-devel mailing list
[hidden email]
http://selenic.com/mailman/listinfo/mercurial-devel

smime.p7s (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] mq: fix the deprecation comment for qsave & qrestore

Matt Mackall
In reply to this post by Dan Villiom Podlaski Christiansen-2
On Mon, 2010-09-20 at 13:33 +0200, Dan Villiom Podlaski Christiansen
wrote:
> # HG changeset patch
> # User Dan Villiom Podlaski Christiansen <[hidden email]>
> # Date 1284982262 -7200
> # Node ID 0b965ece4f058ed0c66bee26425233adc07b5842
> # Parent  6ca072791661e53c9596570490247c0519e12e7e
> mq: fix the deprecation comment for qsave & qrestore.

Queued, thanks.

--
Mathematics is the supreme nostalgia of our time.


_______________________________________________
Mercurial-devel mailing list
[hidden email]
http://selenic.com/mailman/listinfo/mercurial-devel
Loading...