D8331: py3: make setup.py's hgcommand() consistently return bytes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

D8331: py3: make setup.py's hgcommand() consistently return bytes

martinvonz (Martin von Zweigbergk)
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Before this patch, it returned unicode when the command failed. That
  made e.g. `make local PYTHON=python3` fail on an obsolete commit.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8331

AFFECTED FILES
  setup.py

CHANGE DETAILS

diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -267,7 +267,7 @@
         if err or returncode != 0:
             printf("stderr from '%s':" % (' '.join(cmd)), file=sys.stderr)
             printf(err, file=sys.stderr)
-            return ''
+            return b''
         return out
 
 



To: martinvonz, #hg-reviewers
Cc: mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[hidden email]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Reply | Threaded
Open this post in threaded view
|

D8331: py3: make setup.py's hgcommand() consistently return bytes

martinvonz (Martin von Zweigbergk)
Closed by commit rHGbda050bc9987: py3: make setup.py's hgcommand() consistently return bytes (authored by martinvonz).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8331?vs=20886&id=20888

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8331/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8331

AFFECTED FILES
  setup.py

CHANGE DETAILS

diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -274,7 +274,7 @@
         if err or returncode != 0:
             printf("stderr from '%s':" % (' '.join(cmd)), file=sys.stderr)
             printf(err, file=sys.stderr)
-            return ''
+            return b''
         return out
 
 



To: martinvonz, #hg-reviewers, mharbison72, pulkit
Cc: mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[hidden email]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel