D8034: check-code: allow `hg cp -r`, by using a negative lookbehind

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

D8034: check-code: allow `hg cp -r`, by using a negative lookbehind

mharbison72 (Matt Harbison)
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8034

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -183,7 +183,7 @@
             "don't use 'sed ... \\n', use a \\ and a newline",
         ),
         (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
-        (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
+        (r'(?<!hg )cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
         (r'grep.* -[ABC]', "don't use grep's context flags"),
         (
             r'find.*-printf',



To: martinvonz, #hg-reviewers
Cc: mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[hidden email]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Reply | Threaded
Open this post in threaded view
|

D8034: check-code: allow `hg cp -r`, by using a negative lookbehind

mharbison72 (Matt Harbison)
marmoute added a comment.


  See my comment in D8030 <https://phab.mercurial-scm.org/D8030>, the feature is interresting, but it seems to me that we should implement that through regular amend.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8034/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8034

To: martinvonz, #hg-reviewers
Cc: marmoute, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[hidden email]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Reply | Threaded
Open this post in threaded view
|

D8034: check-code: allow `hg cp -r`, by using a negative lookbehind

mharbison72 (Matt Harbison)
In reply to this post by mharbison72 (Matt Harbison)
durin42 added a comment.


  I think this is obsolete now? Maybe?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8034/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8034

To: martinvonz, #hg-reviewers
Cc: durin42, marmoute, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[hidden email]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Reply | Threaded
Open this post in threaded view
|

D8034: check-code: allow `hg cp -r`, by using a negative lookbehind

mharbison72 (Matt Harbison)
In reply to this post by mharbison72 (Matt Harbison)
This revision is now accepted and ready to land.
durin42 added a comment.
durin42 accepted this revision.


  Nevermind, I misread.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8034/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8034

To: martinvonz, #hg-reviewers, durin42
Cc: durin42, marmoute, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[hidden email]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Reply | Threaded
Open this post in threaded view
|

D8034: check-code: allow `hg cp -r`, by using a negative lookbehind

mharbison72 (Matt Harbison)
In reply to this post by mharbison72 (Matt Harbison)
martinvonz added a comment.
martinvonz abandoned this revision.


  No longer needed now that we've renamed `-r` to `--at-rev`.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8034/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8034

To: martinvonz, #hg-reviewers, durin42
Cc: durin42, marmoute, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[hidden email]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel