D6810: revlog: use the new sidedata map return in the sidedata method

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

D6810: revlog: use the new sidedata map return in the sidedata method

martinvonz (Martin von Zweigbergk)
marmoute created this revision.
marmoute added reviewers: yuja, durin42.
Herald added a reviewer: indygreg.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  So far things, seems logical.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6810

AFFECTED FILES
  mercurial/revlog.py

CHANGE DETAILS

diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -1619,8 +1619,8 @@
         mapping object will likely be used in the future for a more
         efficient/lazy code.
         """
-        # XXX will actualy return data once storage is implemented.
-        return {}
+        text, sidemeta = self._revision(nodeorrev, _df)[1]
+        return sidemeta
 
     def _revisiondata(self, nodeorrev, _df=None, raw=False):
         # deal with <nodeorrev> argument type



To: marmoute, yuja, durin42, indygreg, #hg-reviewers
Cc: mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[hidden email]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Reply | Threaded
Open this post in threaded view
|

D6810: revlog: use the new sidedata map return in the sidedata method

martinvonz (Martin von Zweigbergk)
marmoute updated this revision to Diff 16476.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6810?vs=16415&id=16476

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6810/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6810

AFFECTED FILES
  mercurial/revlog.py

CHANGE DETAILS

diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -1623,8 +1623,8 @@
         mapping object will likely be used in the future for a more
         efficient/lazy code.
         """
-        # XXX will actualy return data once storage is implemented.
-        return {}
+        text, sidemeta = self._revision(nodeorrev, _df)[1]
+        return sidemeta
 
     def _revisiondata(self, nodeorrev, _df=None, raw=False):
         # deal with <nodeorrev> argument type



To: marmoute, yuja, durin42, indygreg, #hg-reviewers
Cc: mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[hidden email]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Reply | Threaded
Open this post in threaded view
|

D6810: revlog: use the new sidedata map return in the sidedata method

martinvonz (Martin von Zweigbergk)
In reply to this post by martinvonz (Martin von Zweigbergk)
marmoute updated this revision to Diff 16491.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6810?vs=16476&id=16491

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6810/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6810

AFFECTED FILES
  mercurial/revlog.py

CHANGE DETAILS

diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -1623,8 +1623,7 @@
         mapping object will likely be used in the future for a more
         efficient/lazy code.
         """
-        # XXX will actualy return data once storage is implemented.
-        return {}
+        return self._revisiondata(nodeorrev, _df)[1]
 
     def _revisiondata(self, nodeorrev, _df=None, raw=False):
         # deal with <nodeorrev> argument type



To: marmoute, yuja, durin42, indygreg, #hg-reviewers
Cc: mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[hidden email]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Reply | Threaded
Open this post in threaded view
|

D6810: revlog: use the new sidedata map return in the sidedata method

martinvonz (Martin von Zweigbergk)
In reply to this post by martinvonz (Martin von Zweigbergk)
Closed by commit rHG9d62f9fa332f: revlog: use the new sidedata map return in the sidedata method (authored by marmoute).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6810?vs=16491&id=16630

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6810/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6810

AFFECTED FILES
  mercurial/revlog.py

CHANGE DETAILS

diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -1623,8 +1623,7 @@
         mapping object will likely be used in the future for a more
         efficient/lazy code.
         """
-        # XXX will actualy return data once storage is implemented.
-        return {}
+        return self._revisiondata(nodeorrev, _df)[1]
 
     def _revisiondata(self, nodeorrev, _df=None, raw=False):
         # deal with <nodeorrev> argument type



To: marmoute, yuja, durin42, indygreg, #hg-reviewers
Cc: mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[hidden email]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel